[llvm-commits] [PATCH] LIT cleanup phase #2 - remove remaining traces of dg.exp and refactor some lit.local.cfg files

Daniel Dunbar daniel at zuster.org
Wed Mar 21 09:31:41 PDT 2012


Hey Eli,

Patch looks awesome, thanks!

 - Daniel

On Sat, Mar 10, 2012 at 9:54 PM, Bendersky, Eli <eli.bendersky at intel.com> wrote:
> Ping #2
>
>
>
> From: llvm-commits-bounces at cs.uiuc.edu
> [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Bendersky, Eli
>
>
> Sent: Sunday, March 04, 2012 09:20
> To: llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] [PATCH] LIT cleanup phase #2 - remove remaining
> traces of dg.exp and refactor some lit.local.cfg files
>
>
>
> Ping
>
>
>
> From: llvm-commits-bounces at cs.uiuc.edu
> [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Bendersky, Eli
> Sent: Tuesday, February 28, 2012 15:55
> To: llvm-commits at cs.uiuc.edu
> Subject: [llvm-commits] [PATCH] LIT cleanup phase #2 - remove remaining
> traces of dg.exp and refactor some lit.local.cfg files
>
>
>
> Hello,
>
>
>
> This patch complements the previous one
> (http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120206/136578.html):
>
> Specifically, in this patch:
>
>
>
> -          Removed test/lib/llvm.exp - it is no longer needed
>
> -          Deleted the dg.exp reading code from test/lit.cfg. There are no
> dg.exp files left in the test suite so this code is no longer required.
> test/lit.cfg is now much shorter and clearer
>
> -          Removed a lot of duplicate code in lit.local.cfg files that need
> access to the root configuration, by adding a “root” attribute to the
> TestingConfig object. This attribute is dynamically computed to provide the
> same information as was previously provided by the custom getRoot functions.
>
> -          Documented the config.root attribute in docs/CommandGuide/lit.pod
> (although this change won’t be visible on llvm.org due to
> http://lists.cs.uiuc.edu/pipermail/llvmdev/2012-January/047141.html)
>
>
>
> Please review,
>
> Eli
>
>
>
> ---------------------------------------------------------------------
> Intel Israel (74) Limited
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
> ---------------------------------------------------------------------
> Intel Israel (74) Limited
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
> ---------------------------------------------------------------------
> Intel Israel (74) Limited
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>




More information about the llvm-commits mailing list