[llvm-commits] [LLVM] [MC Disassembler] Addding support for dissassembler for MIPS

[Rafael Espíndola]

On 16 March 2012 11:45, Medic, Vladimir <vmedic at mips.com> wrote:
> Hi everyone,
> here is a patch that adds support for MIPS Disassembler. Comments are
> welcome.

First of all, thanks for doing this and for all the tests!

Nits:

> +
 > // Mips Pseudo Instructions Format

Do you want the extra line?


+  std::string TheTriple;

This can be a StringRef, no?

Given https://groups.google.com/group/llvm-dev/msg/d5c2be88fb5d0f1e ,
can you use isPseudo instead of isCodeGenOnly?

Cheers,
Rafael