[llvm-commits] Is this correct? [polly] r153318 - /polly/trunk/lib/IndVarSimplify.cpp

[Tobias Grosser]

Hi Andrew,

I am about to fix Polly after your EnableIVRewrite changes. As ether 
pointed out, your patch was not sufficient to fix compilation, as the 
simplifyIVUsers function was removed. I worked around this by just not 
calling it. This works for a very simple test case and was the fastest 
solution I could find.

I do not want to spend too much time on this, as this code should 
disappear anyway. Still, could you have a short look. Does the patch 
make sense, assuming we need canonical induction variables, but not 
minimal scalar code. (Later passes will hopefully clean this up). Is 
there are simple solution to improve on this?

Thanks
Tobi

-------- Original Message --------
Subject: [llvm-commits] [polly] r153318 - 
/polly/trunk/lib/IndVarSimplify.cpp
Date: Fri, 23 Mar 2012 08:02:19 -0000
From: Tobias Grosser <grosser at fim.uni-passau.de>
To: llvm-commits at cs.uiuc.edu

Author: grosser
Date: Fri Mar 23 03:02:19 2012
New Revision: 153318

URL: http://llvm.org/viewvc/llvm-project?rev=153318&view=rev
Log:
IndVarSimplify: Disable simplifyIVUsers

This functionality is not available in LLVM trunk and breaks the 
compilation of
Polly. This patch fixes the compilation, but may not be enough to 
recover all
functionality.

Modified:
     polly/trunk/lib/IndVarSimplify.cpp

Modified: polly/trunk/lib/IndVarSimplify.cpp
URL: 
http://llvm.org/viewvc/llvm-project/polly/trunk/lib/IndVarSimplify.cpp?rev=153318&r1=153317&r2=153318&view=diff
==============================================================================
--- polly/trunk/lib/IndVarSimplify.cpp (original)
+++ polly/trunk/lib/IndVarSimplify.cpp Fri Mar 23 03:02:19 2012
@@ -1846,8 +1846,13 @@
      RewriteLoopExitValues(L, Rewriter);

    // Eliminate redundant IV users.
-  if (EnableIVRewrite)
-    Changed |= simplifyIVUsers(IU, SE, &LPM, DeadInsts);
+  // FIXME: Disabled as the function was removed from LLVM trunk. We 
may get
+  //        along with this, as Polly does not need a lot of 
simplifications,
+  //        but just a canonical induction variable. In the near future, we
+  //        should remove the need of canonical induction variables all
+  //        together.
+  //if (EnableIVRewrite)
+  //  Changed |= simplifyIVUsers(IU, SE, &LPM, DeadInsts);

    // Eliminate redundant IV cycles.
    if (!EnableIVRewrite)


_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits