[llvm-commits] [PATCH 1/6] [llvm-c] Implement needed libraries for ObjectFile

[Gregory Szorc]

I may rescind this patch/review series.

IMO the iteration model of the Object interface is screwy. I'm not sure
if I want to add on top of it.

I would much prefer an iteration model that went something like:

Iterator LLVMGetNeededLibraryIterator(ObjectFile)
NeededLibrary LLVMGetLibraryFromIterator(Iterator)

// Return current object and advance iterator. Return NULL if at the
// end of the iterator.
NeededLibrary LLVMAdvanceNeededLibraryIterator(Iterator)

char * LLVMGetNeededLibraryName(NeededLibrary)

void LLVMDisposeIterator(Iterator)

// Optionally, if needed.
void LLVMDiposeNeededLibrary(NeededLibrary)


What do people think?


On 3/18/2012 9:12 PM, Gregory Szorc wrote:
> ---
>  include/llvm-c/Object.h |   36 ++++++++++++++++++++++++++++++++++++
>  lib/Object/Object.cpp   |   28 ++++++++++++++++++++++++++++
>  2 files changed, 64 insertions(+), 0 deletions(-)
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits