[llvm-commits] [PATCH 5/6] [llvm-c] Add architecture type enumeration

Anton Korobeynikov anton at korobeynikov.info
Mon Mar 19 03:55:05 PDT 2012


> I assume the value of enum values must match those in the
> Triple::ArchType enum. Someone could easily add / remove a target there
> without realizing the need to update the C bindings. I think it might be
> worth adding a comment to Triple.h indicating that the
> LLVMArchitectureType enum must be updated whenever the Triple::ArchType
> enum is changed.
Or maybe even some compiler time assert to enforce this? :)

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University



More information about the llvm-commits mailing list