[llvm-commits] [llvm] r152497 - in /llvm/trunk: lib/Analysis/InstructionSimplify.cpp test/Transforms/InstCombine/2012-03-10-InstCombine.ll

[Bill Wendling]

On Mar 10, 2012, at 10:06 AM, Duncan Sands <baldrick at free.fr> wrote:

> Hi Bill,
> 
>> --- llvm/trunk/lib/Analysis/InstructionSimplify.cpp (original)
>> +++ llvm/trunk/lib/Analysis/InstructionSimplify.cpp Sat Mar 10 11:56:03 2012
>> @@ -1609,23 +1609,33 @@
>>      if (llvm::isKnownNonNull(LHSPtr) || llvm::isKnownNonNull(RHSPtr)) {
>>        // If both sides are different identified objects, they aren't equal
>>        // unless they're null.
>> -      if (LHSPtr != RHSPtr&&  llvm::isIdentifiedObject(RHSPtr))
>> -        return ConstantInt::get(ITy, CmpInst::isFalseWhenEqual(Pred));
>> +      if (LHSPtr != RHSPtr&&  llvm::isIdentifiedObject(RHSPtr)&&
>> +          (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::FCMP_UEQ))
> 
> these are pointers, so why the floating point compare predicate FCMP_UEQ?
> Likewise below.
> 
Wha?! You don't believe in future technology? ;-)

Will change. Thanks for the review.

-bw