[llvm-commits] [llvm] r152148 - /llvm/trunk/utils/TableGen/CodeEmitterGen.cpp

NAKAMURA Takumi geek4civic at gmail.com
Fri Mar 9 07:25:05 PST 2012


2012/3/7 Owen Anderson <resistor at mac.com>:
> --- llvm/trunk/utils/TableGen/CodeEmitterGen.cpp (original)
> +++ llvm/trunk/utils/TableGen/CodeEmitterGen.cpp Tue Mar  6 15:48:32 2012
> @@ -163,7 +163,7 @@
>       --bit;
>     }
>
> -    unsigned opMask = ~0U >> (32-N);
> +    uint64_t opMask = ~0U >> (64-N);
>     int opShift = beginVarBit - N + 1;
>     opMask <<= opShift;
>     opShift = beginInstBit - beginVarBit;

I guess ~0U might be interpreted as (uint64_t)~(uint32_t)0, ... to
0x00000000_FFFFFFFF on certain host.

I have tweaked it in r152407. I would be happy if you reconfirmed
mine, thank you.

-    uint64_t opMask = ~0U >> (64-N);
+    uint64_t opMask = ~(uint64_t)0 >> (64-N);

...Takumi




More information about the llvm-commits mailing list