[llvm-commits] [llvm] r152195 - /llvm/trunk/lib/Analysis/ValueTracking.cpp

[Nick Lewycky]

Author: nicholas
Date: Tue Mar  6 20:27:53 2012
New Revision: 152195

URL: http://llvm.org/viewvc/llvm-project?rev=152195&view=rev
Log:
No functionality change. Type::isSized() can be expensive, so avoid calling it
until after other inexpensive tests.

Modified:
    llvm/trunk/lib/Analysis/ValueTracking.cpp

Modified: llvm/trunk/lib/Analysis/ValueTracking.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ValueTracking.cpp?rev=152195&r1=152194&r2=152195&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/ValueTracking.cpp (original)
+++ llvm/trunk/lib/Analysis/ValueTracking.cpp Tue Mar  6 20:27:53 2012
@@ -106,16 +106,18 @@
   // The address of an aligned GlobalValue has trailing zeros.
   if (GlobalValue *GV = dyn_cast<GlobalValue>(V)) {
     unsigned Align = GV->getAlignment();
-    if (Align == 0 && TD && GV->getType()->getElementType()->isSized()) {
+    if (Align == 0 && TD) {
       if (GlobalVariable *GVar = dyn_cast<GlobalVariable>(GV)) {
         Type *ObjectType = GVar->getType()->getElementType();
-        // If the object is defined in the current Module, we'll be giving
-        // it the preferred alignment. Otherwise, we have to assume that it
-        // may only have the minimum ABI alignment.
-        if (!GVar->isDeclaration() && !GVar->isWeakForLinker())
-          Align = TD->getPreferredAlignment(GVar);
-        else
-          Align = TD->getABITypeAlignment(ObjectType);
+        if (ObjectType->isSized()) {
+          // If the object is defined in the current Module, we'll be giving
+          // it the preferred alignment. Otherwise, we have to assume that it
+          // may only have the minimum ABI alignment.
+          if (!GVar->isDeclaration() && !GVar->isWeakForLinker())
+            Align = TD->getPreferredAlignment(GVar);
+          else
+            Align = TD->getABITypeAlignment(ObjectType);
+        }
       }
     }
     if (Align > 0)