[llvm-commits] [llvm] r151466 - in /llvm/trunk: include/llvm/Analysis/Dominators.h lib/Analysis/InstructionSimplify.cpp

[Chris Lattner]

On Mar 6, 2012, at 12:17 PM, Rafael Espíndola wrote:

>> 
>> "dominatesUse()" was ok, but as Duncan pointed out could be misleading, since there's no assumption of data flow between operands. "properlyDominates()" could be misleading because of the unreachable case above, and theoretically wrong because "proper" dominance essentially refers nodes in the domtree, not instructions. I just don't have a better idea.
> 
> Same here. Chris, just waiting for you OK on
> 
> * Dominates for BB is changed so that anything dominates an
>  unreachable block. This does create a case where
>  A != B && dominates(A, B) && dominates(B,A) is true.
> 
> :-)

Sounds fine to me.  I think that this would eliminate some cases where we have to say that "something dominates or is in an unreachable block".

-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120306/85b4a1d0/attachment.html>