[llvm-commits] [llvm] r152019 - in /llvm/trunk: include/llvm/MC/MCRegisterInfo.h utils/TableGen/RegisterInfoEmitter.cpp

[Craig Topper]

The maximum physical registers on all targets supported today is less than
300. Do we really expect it to grow by a factor of 200?

On Mon, Mar 5, 2012 at 10:26 AM, Jakob Stoklund Olesen <stoklund at 2pi.dk>wrote:

>
> On Mar 5, 2012, at 12:33 AM, Craig Topper wrote:
>
> > Author: ctopper
> > Date: Mon Mar  5 02:33:33 2012
> > New Revision: 152019
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=152019&view=rev
> > Log:
> > Shrink and reorder fields in MCRegisterClass to reduce size of static
> data.
> >
> > Modified:
> >    llvm/trunk/include/llvm/MC/MCRegisterInfo.h
> >    llvm/trunk/utils/TableGen/RegisterInfoEmitter.cpp
> >
> > Modified: llvm/trunk/include/llvm/MC/MCRegisterInfo.h
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCRegisterInfo.h?rev=152019&r1=152018&r2=152019&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/include/llvm/MC/MCRegisterInfo.h (original)
> > +++ llvm/trunk/include/llvm/MC/MCRegisterInfo.h Mon Mar  5 02:33:33 2012
> > @@ -28,15 +28,15 @@
> >   typedef const uint16_t* iterator;
> >   typedef const uint16_t* const_iterator;
> >
> > -  const unsigned ID;
> >   const char *Name;
> > -  const unsigned RegSize, Alignment; // Size & Alignment of register in
> bytes
> > -  const int CopyCost;
> > -  const bool Allocatable;
> >   const iterator RegsBegin;
> >   const uint8_t *const RegSet;
> > -  const unsigned RegsSize;
> > -  const unsigned RegSetSize;
> > +  const uint8_t RegsSize;
> > +  const uint8_t RegSetSize;
> > +  const uint8_t ID;
> > +  const uint8_t RegSize, Alignment; // Size & Alignment of register in
> bytes
> > +  const int8_t CopyCost;
> > +  const bool Allocatable;
>
> Sorry, Craig. This is going way too far. Please revert this.
>
> Do not limit the number of physregs below 64k.
>
> /jakob
>
>


-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120305/6030ae8c/attachment.html>