[llvm-commits] PATCH: Switch StringMap to the new hashing infrastructure

Jay Foad jay.foad at gmail.com
Mon Mar 5 03:15:35 PST 2012


On 5 March 2012 10:17, Chandler Carruth <chandlerc at google.com> wrote:
> The measured changes in performance are all down into the noise floor,
> despite everything I did to lower that. From what I can tell, this change
> has no observable performance impact, and reduces the number of hashing
> functions in use. Good to commit?

I like it.

I notice that the patch doesn't actually remove HashString, because
it's still used in loads of other places. Do you plan to convert them
so that we can *really* "reduce the number of hashing functions in
use"? (If you don't plan to do it yourself I suppose it would make a
good beginner's project for someone else.)

Jay.



More information about the llvm-commits mailing list