[llvm-commits] AddressSanitizer: Make GetOSVersion available on all platforms (issue 5702060)

kcc at google.com kcc at google.com
Thu Mar 1 15:24:28 PST 2012


> > For this statement, I would prefer something like
> >   if (PlatformHasDifferentMemcpyAndMemmove)
> I think we may end up with too much flags/functions of that kind.
> if (PlatformNeedsGetPcSpBp)?

I see no problem with this.

> >
> >
> > BTW, Maybe it's better to implement internal_memcpy?
> > (It will have to be highly performant)
> Why do we need this? Not a problem, of course.
Maybe we don't need it.



http://codereview.appspot.com/5702060/



More information about the llvm-commits mailing list