[llvm-commits] [llvm] r151620 - in /llvm/trunk: lib/Transforms/Scalar/DeadStoreElimination.cpp test/Transforms/DeadStoreElimination/OverwriteStoreStart.ll

[Peter Cooper]

Hi Chandler

Thanks for the comments. The source comment is meant to say that the alignment of the memset will not be changed, ie, well only trim it by aligned amounts. I'll add some more tests for vectors. Also I just had to revert this due to buildbot failures do it needs much more work.

Thanks
Pete

Sent from my iPhone

On Feb 27, 2012, at 8:43 PM, Chandler Carruth <chandlerc at google.com> wrote:

> On Mon, Feb 27, 2012 at 8:27 PM, Pete Cooper <peter_cooper at apple.com> wrote:
> DSE: Shorten memset when a later store overwrites the start of it
> 
> Not 100% sure I understand the comments, but this won't shorten the memset if its address has favorable alignment constraints, or this would make a vector store become a scalar store? It would be good to have some test cases to clearly demonstrate where this should and shouldn't fire there... It might be that I've misread them, but I only see fairly limited testing of the negative cases here. (Perhaps just comments on what the test cases are actually checking would help...)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120227/b10b172c/attachment.html>