[llvm-commits] [llvm] r151471 - /llvm/trunk/lib/Analysis/ScalarEvolutionExpander.cpp

[Chad Rosier]

Hi Rafael,
One of the benchmarks from the test-suite (MultiSource/Benchmarks/PAQ8p/paq8p) is hitting this assert.  We have two other regressions (i.e., miscompiles) in the SPEC suite (CFP2006/444_namd and CFP2006/447_dealll), which I bisected to between r151469 and r151472.  Would you mind taking a look at the paq8p regression since that code is publicly available?  I'll send to the steps to reproduce in a PM.

 Chad

On Feb 25, 2012, at 6:29 PM, Rafael Espindola <rafael.espindola at gmail.com> wrote:

> Author: rafael
> Date: Sat Feb 25 20:29:18 2012
> New Revision: 151471
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=151471&view=rev
> Log:
> Enable the assert that got all this dominator work started.
> 
> Modified:
>    llvm/trunk/lib/Analysis/ScalarEvolutionExpander.cpp
> 
> Modified: llvm/trunk/lib/Analysis/ScalarEvolutionExpander.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ScalarEvolutionExpander.cpp?rev=151471&r1=151470&r2=151471&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Analysis/ScalarEvolutionExpander.cpp (original)
> +++ llvm/trunk/lib/Analysis/ScalarEvolutionExpander.cpp Sat Feb 25 20:29:18 2012
> @@ -44,7 +44,7 @@
>   BasicBlock::iterator BIP = Builder.GetInsertPoint();
> 
>   // FIXME: enable once our implementation of dominates is fixed.
> -  //  assert(BIP == IP || SE.DT->dominates(IP, BIP));
> +  assert(BIP == IP || SE.DT->dominates(IP, BIP));
> 
>   // Check to see if there is already a cast!
>   for (Value::use_iterator UI = V->use_begin(), E = V->use_end();
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits