[llvm-commits] [ASan] Intercept CreateThread on Windows (issue 5699064)

[samsonov at google.com]

LGTM


http://codereview.appspot.com/5699064/diff/1017/lib/asan/asan_interceptors.cc
File lib/asan/asan_interceptors.cc (right):

http://codereview.appspot.com/5699064/diff/1017/lib/asan/asan_interceptors.cc#newcode585
lib/asan/asan_interceptors.cc:585: DWORD (__stdcall
*start_routine)(void*), void* arg,
On 2012/02/24 15:24:59, timurrrr_at_google_com wrote:
> On 2012/02/24 15:20:38, samsonov wrote:
> > why not use thread_callback_t here and in pthread_create
interceptor?
> I want the types here to be comparable with that in the docs (e.g.
MSDN).

> If the types begin to mismatch, the compile will report an error at
the first
> use (line 592)

reasonable

http://codereview.appspot.com/5699064/