[llvm-commits] [llvm] r151200 - in /llvm/trunk: include/llvm/CodeGen/AsmPrinter.h lib/CodeGen/AsmPrinter/AsmPrinter.cpp lib/Target/PowerPC/PPCAsmPrinter.cpp test/CodeGen/PowerPC/ppc64-linux-func-size.ll

[Hal Finkel]

On Wed, 22 Feb 2012 23:11:47 +0100
Roman Divacky <rdivacky at freebsd.org> wrote:

> 
> grrr.. I misread , as . there should be two symbols emitted. Here's
> the updated patch. Please review.

My test system seems happy with this, so this is fine by me!

Thanks again,
Hal

> 
> On Wed, Feb 22, 2012 at 10:49:59PM +0100, Roman Divacky wrote:
> > > Modified: llvm/trunk/lib/Target/PowerPC/PPCAsmPrinter.cpp
> > > URL:
> > > http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCAsmPrinter.cpp?rev=151200&r1=151199&r2=151200&view=diff
> > > ==============================================================================
> > > --- llvm/trunk/lib/Target/PowerPC/PPCAsmPrinter.cpp (original)
> > > +++ llvm/trunk/lib/Target/PowerPC/PPCAsmPrinter.cpp Wed Feb 22
> > > 15:11:47 2012 @@ -398,7 +398,11 @@
> > > OutStreamer.EmitRawText("\t.quad .L." +
> > > Twine(CurrentFnSym->getName()) + ",.TOC. at tocbase");
> > > OutStreamer.EmitRawText(StringRef("\t.previous"));
> > > -  OutStreamer.EmitRawText(".L." + Twine(CurrentFnSym->getName())
> > > + ":"); +
> > > +  MCSymbol *RealFnSym = OutContext.GetOrCreateSymbol(
> > > +                          ".L." +
> > > Twine(CurrentFnSym->getName()));
> > > +  OutStreamer.EmitLabel(RealFnSym);
> > > +  CurrentFnSymForSize = RealFnSym;
> > >  }
> > 
> > The EmitRawText here must vanish. Are you ok with the attached
> > patch? It properly MCizes this. If you dont object I'd like to
> > (finaly) commit that.
> > 
> > roman
> 
> 
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 



-- 
Hal Finkel
Postdoctoral Appointee
Leadership Computing Facility
Argonne National Laboratory