[llvm-commits] [ASan] Intercept functions on Windows - first version (issue 5690065)

[Alexey Samsonov]

On Wed, Feb 22, 2012 at 5:16 PM, <samsonov at google.com> wrote:

> On 2012/02/22 13:04:16, timurrrr_at_google_com wrote:
>
>> Hi Alexander, Evgeniy,
>>
>
>  Can you please review this patch?
>> It adds some basic support for function interception on Windows.
>>
>
> IMO InitializeAllInterceptors() really does look horrible now :)
> I think we need to use functions like:
> InitializeSignalInterceptors()
> InitializePthreadInterceptors(**)
> InitializeGCDInterceptors()
> and so on. Probably these functions can be defined in their own .cc
> file, but even now they may simplify things.
>
> Also, what about using if (ASAN_WINDOWS)?
>

omg, if (ASAN_WINDOWS) can be a problem as we'll still need to resolve
symbols
that can be undefined on a given os.


>
>  Thanks,
>> Timur
>>
>
>
>
> http://codereview.appspot.com/**5690065/<http://codereview.appspot.com/5690065/>
>



-- 
Alexey Samsonov
Software Engineer, Moscow
samsonov at google.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120222/5d319ad8/attachment.html>