[llvm-commits] [llvm] r150939 - /llvm/trunk/lib/Transforms/IPO/GlobalOpt.cpp

[Chris Lattner]

On Feb 19, 2012, at 7:30 PM, Nick Lewycky wrote:

> Chris Lattner wrote:
>> 
>> On Feb 19, 2012, at 4:37 PM, NAKAMURA Takumi wrote:
>> 
>>> 2012/2/20 Chris Lattner<clattner at apple.com>:
>>>> Nice!  It's probably best to rename the "Evaluate" class to "Evaluator".  Also, it can be put into an anon namespace.  Thanks Nick!
>>> 
>>> Rather, could we integrate the evaluators in globalopt,
>>> constantfolding (and EE/Interpreter)?
>> 
>> They all do different things (and the interpreter should be killed :), so I don't think it makes sense.
> 
> I think it would make sense. They share a design where they visit each an instruction/constant-expression with some mapping applied to the operands such as building a Constant* or computing a ConstantRange or using a SCEV object.

This sounds like InstVisitor.  A patch to kill off the interpreter is heartily appreciated.

-Chris