[llvm-commits] [ASan] Author one FIXME - re-enable "free-not-malloced" reports on Windows (issue 5688058)

[timurrrr at google.com]

Reviewers: Evgeniy Stepanov,

Message:
Hi Evgeniy,

Can you please take a look at this small CL?

Thanks,
Timur

Description:
Author one FIXME - re-enable "free-not-malloced" reports on Windows

Please review this at http://codereview.appspot.com/5688058/

Affected files:
   M lib/asan/asan_allocator.cc


Index: lib/asan/asan_allocator.cc
diff --git a/lib/asan/asan_allocator.cc b/lib/asan/asan_allocator.cc
index  
28a3ef355fefeb07d5d7f49d8ef6d1621d83b006..5ac22df61b9c54793d3d74e8a475a8da8be7c5ad  
100644
--- a/lib/asan/asan_allocator.cc
+++ b/lib/asan/asan_allocator.cc
@@ -695,11 +695,6 @@ static void Deallocate(uint8_t *ptr, AsanStackTrace  
*stack) {
      Describe((uintptr_t)ptr, 1);
      ShowStatsAndAbort();
    } else if (m->chunk_state != CHUNK_ALLOCATED) {
-    if (ASAN_WINDOWS) {
-      // FIXME: On Windows there are a few extra "unknown free()s"
-      // from __endstdio, need investigating.
-      return;
-    }
      Report("ERROR: AddressSanitizer attempting free on address which was  
not"
             " malloc()-ed: %p\n", ptr);
      stack->PrintStack();