[llvm-commits] [llvm] r151015 - /llvm/trunk/lib/Analysis/ScalarEvolutionExpander.cpp

[Duncan Sands]

Hi Rafael,

> --- llvm/trunk/lib/Analysis/ScalarEvolutionExpander.cpp (original)
> +++ llvm/trunk/lib/Analysis/ScalarEvolutionExpander.cpp Mon Feb 20 19:19:51 2012
> @@ -31,13 +31,11 @@
>   Value *SCEVExpander::ReuseOrCreateCast(Value *V, Type *Ty,
>                                          Instruction::CastOps Op,
>                                          BasicBlock::iterator IP) {
> -  // All new or reused instructions must strictly dominate the Builder's
> -  // InsertPt to ensure that the expression's expansion dominates its uses.
> -  // Assert that the requested insertion point works at least for new
> -  // instructions.
> -
> -  // FIXME: disabled to make the bots happy.
> -  //assert(SE.DT->dominates(IP, Builder.GetInsertPoint()));
> +  // All new or reused instructions must strictly dominate their uses.
> +  // It would be nice to assert this here, but we don't always know where
> +  // the next instructions will be added as the the caller can move the

the the -> the

Ciao, Duncan.