[llvm-commits] [llvm] r150885 - /llvm/trunk/lib/Analysis/ScalarEvolutionExpander.cpp

[Rafael Ávila de Espíndola]

> By the way, if you move this logic into the dominates routine, then I
> guess the
> verifier can be simplified by removing all the current logic and just
> replacing
> by a call to the improved dominator routine.

Thanks again for the review. Exactly what these functions do was a bit
fuzzy in my head.

I really like the idea of sharing as much code as possible. The attached
patches do that, but unfortunately they cannot fully replace the logic
in the verifier. The interface doesn't provide which edge of a phi to
consider, so they have to be conservative and check all.

> Ciao, Duncan.

Cheers,
Rafael
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Rename-dominates-to-dominatesUse.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120221/87a73f96/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0002-Fix-the-implementation.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120221/87a73f96/attachment-0001.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0003-Use-the-DT-dominate-function-in-the-verifier.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120221/87a73f96/attachment-0002.ksh>