[llvm-commits] [PATCH][Review request] AMD SVM support

Craig Topper craig.topper at gmail.com
Sat Feb 18 00:25:56 PST 2012


Looks good to me. Made a few tweaks to reduce some replication. No
functional changes. Committed in r150873.

On Fri, Feb 17, 2012 at 1:45 PM, Kay Tiong Khoo <kkhoo at perfwizard.com>wrote:

> Hi -
>
> This is my first try at an LLVM patch. I'd like to assemble and
> disassemble AMD's SVM (aka Pacifica, aka AMD-V) instruction set.
>
> See here for more details:
> http://llvm.org/bugs/show_bug.cgi?id=12003
>
> Please review and let me know how to proceed.
>
> Note: for anyone that's interested, about 75% of my time doing this work
> was locating the chunk of code in utils/TableGen/EDEmitter.cpp that special
> cases a pile of x86 "call" mnemonic strings (the first instruction that I
> tried to add was "vmmcall")...that was difficult to grep for, and I didn't
> expect to have to look in a non-x86 file for x86-specific disasm
> functionality.
>
> Thanks!
> KK
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>


-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120218/7fc0c379/attachment.html>


More information about the llvm-commits mailing list