[llvm-commits] [llvm] r150848 - /llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp

[Nick Lewycky]

On 17 February 2012 15:24, Chad Rosier <mcrosier at apple.com> wrote:

>
> On Feb 17, 2012, at 3:03 PM, Eric Christopher wrote:
>
> > Author: echristo
> > Date: Fri Feb 17 17:03:39 2012
> > New Revision: 150848
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=150848&view=rev
> > Log:
> > Ignore the lifetime intrinsics in fast-isel.
> >
> > Modified:
> >    llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp
> >
> > Modified: llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp?rev=150848&r1=150847&r2=150848&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp (original)
> > +++ llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp Fri Feb 17 17:03:39
> 2012
> > @@ -567,6 +567,10 @@
> >   // Handle selected intrinsic function calls.
> >   switch (F->getIntrinsicID()) {
> >   default: break;
> > +    // At -O0 we don't care about the lifetime intrinsics.
>
> Which leaves me to wonder if there are any other intrinsics (or IR in
> general) being generated at -O0 that aren't necessary?  This isn't
> necessarily directed at Eric, but the community in general.
>

I've been looking for a name (like "DbgInfoIntrinsic") to wrap up the
intrinsics which are safe to ignore in most contexts. A group for
"optimization hints" that I could isa<> on would be really nice.
("OptznHintIntrinsic"?)

Nick


>  Chad
>
> > +  case Intrinsic::lifetime_start:
> > +  case Intrinsic::lifetime_end:
> > +    return true;
> >   case Intrinsic::dbg_declare: {
> >     const DbgDeclareInst *DI = cast<DbgDeclareInst>(Call);
> >     if (!DIVariable(DI->getVariable()).Verify() ||
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120217/0b6aa0be/attachment.html>