[llvm-commits] [llvm] r150630 - in /llvm/trunk: include/llvm/CodeGen/MachineInstr.h lib/CodeGen/LiveIntervalAnalysis.cpp lib/CodeGen/MachineInstr.cpp

Lang Hames lhames at gmail.com
Thu Feb 16 18:01:54 PST 2012


Indeed. Fixed in r150778.

- Lang.

On Thu, Feb 16, 2012 at 5:39 PM, Evan Cheng <evan.cheng at apple.com> wrote:

> I think this is wrong. You're using a reverse iterator. --MII actually
> moves down, not up.
>
> Evan
>
> On Feb 15, 2012, at 3:21 PM, Lang Hames wrote:
>
> >
> > +MachineInstr* MachineInstr::getBundleStart() {
> > +  if (!isInsideBundle())
> > +    return this;
> > +  MachineBasicBlock::reverse_instr_iterator MII(this);
> > +  --MII;
> > +  while (MII->isInsideBundle())
> > +    --MII;
> > +  return &*MII;
> > +}
> > +
> > bool MachineInstr::isStackAligningInlineAsm() const {
> >   if (isInlineAsm()) {
> >     unsigned ExtraInfo = getOperand(InlineAsm::MIOp_ExtraInfo).getImm();
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120216/a41ef14a/attachment.html>


More information about the llvm-commits mailing list