[llvm-commits] [llvm] r150694 - /llvm/trunk/lib/Analysis/InstructionSimplify.cpp

[Benjamin Kramer]

On 16.02.2012, at 16:21, Duncan Sands wrote:

> Hi Benjamin,
> 
>> --- llvm/trunk/lib/Analysis/InstructionSimplify.cpp (original)
>> +++ llvm/trunk/lib/Analysis/InstructionSimplify.cpp Thu Feb 16 09:03:04 2012
>> @@ -1542,6 +1542,10 @@
>>    Type *ITy = GetCompareTy(LHS); // The return type.
>>    Type *OpTy = LHS->getType();   // The operand type.
>> 
>> +  // Remove pointer casts that don't change the value.
>> +  LHS = LHS->stripPointerCasts();
>> +  RHS = RHS->stripPointerCasts();
> 
> unfortunately it does change the type, which means that the routine has to be
> carefully audited to be sure that that doesn't matter.  Sorry I didn't think
> of this earlier.

I didn't think of this either :(

Reverted in r150695.

- Ben
> Ciao, Duncan.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits