[llvm-commits] Remove calls to library strtol/atoll from ASan RTL (issue 5656075)
eugenis at google.com
eugenis at google.com
Thu Feb 16 06:43:18 PST 2012
http://codereview.appspot.com/5656075/diff/1/asan_interceptors.cc
File asan_interceptors.cc (right):
http://codereview.appspot.com/5656075/diff/1/asan_interceptors.cc#newcode107
asan_interceptors.cc:107: while (isspace(*nptr)) nptr++;
Shall we avoid isspace, isdigit, etc as well?
They are locale dependent and might (I'm not sure about this) try to
open locale database.
http://codereview.appspot.com/5656075/diff/1/asan_interceptors.cc#newcode118
asan_interceptors.cc:118: res = (res * 10) + ((*nptr) - '0');
Check for overflow. It's undefined behaviour for signed types.
http://codereview.appspot.com/5656075/
More information about the llvm-commits
mailing list