[llvm-commits] [llvm] r150607 - in /llvm/trunk: include/llvm/CodeGen/DFAPacketizer.h lib/CodeGen/DFAPacketizer.cpp

[Andrew Trick]

On Feb 15, 2012, at 1:07 PM, Matt Beaumont-Gay <matthewbg at google.com> wrote:

> On Wed, Feb 15, 2012 at 10:55, Andrew Trick <atrick at apple.com> wrote:
>> 
>> +
>> +namespace llvm {
>> +// DefaultVLIWScheduler - This class extends ScheduleDAGInstrs and overrides
>> +// Schedule method to build the dependence graph.
>> +class DefaultVLIWScheduler : public ScheduleDAGInstrs {
> 
> Should this have LLVM_LIBRARY_VISIBILITY? GCC complains thusly:
> lib/CodeGen/DFAPacketizer.cpp:106:7: error:
> 'llvm::DefaultVLIWScheduler' declared with greater visibility than the
> type of its field 'llvm::DefaultVLIWScheduler::<anonymous>'
> [-Werror=attributes]
> lib/CodeGen/DFAPacketizer.cpp:106:7: error:
> 'llvm::DefaultVLIWScheduler' declared with greater visibility than its
> base 'llvm::ScheduleDAGInstrs' [-Werror=attributes]
> 
> (Shame on GCC for that first diagnostic. Shame on Clang for no diagnostics...)
> 
> -Matt

Thanks!  Fixed in r150619.

I don't see any reason that class needs to be exposed. Sundeep can change it back (with properly scoped namespace) if there is a good reason.

-Andy