[llvm-commits] [llvm] r135569 - in /llvm/trunk: include/llvm/CodeGen/ include/llvm/MC/ include/llvm/Target/ lib/CodeGen/ lib/CodeGen/AsmPrinter/ lib/MC/ lib/MC/MCDisassembler/ lib/MC/MCParser/ lib/Target/ lib/Target/ARM/MCTargetDesc/ lib/Target/C

Anton Korobeynikov anton at korobeynikov.info
Wed Feb 15 11:14:32 PST 2012


Hi Evan,

Sorry for resurrecting the old commit.

> +  const MCSection *getEHFrameSection() {
> +    if (!EHFrameSection)
> +      InitEHFrameSection();
> +    return EHFrameSection;
> +  }
What's the point of such on-demand initialization? This does not make
any sense at all. Even more, the probability of seeing / using EH
frame section is much more than e.g. any TLS section.
It seems that InitEHFrameSection() should be removed and the
corresponding code merged into initialization method.

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University




More information about the llvm-commits mailing list