[llvm-commits] [ASan] Define an internal implementation of strchr to make stack OOB tests pass (issue 5668047)

timurrrr at google.com timurrrr at google.com
Tue Feb 14 10:26:50 PST 2012


http://codereview.appspot.com/5668047/diff/4/lib/asan/asan_interceptors.cc
File lib/asan/asan_interceptors.cc (right):

http://codereview.appspot.com/5668047/diff/4/lib/asan/asan_interceptors.cc#newcode112
lib/asan/asan_interceptors.cc:112: char* internal_strchr(const char *s,
int c) {
On 2012/02/14 18:18:27, ramosian.glider wrote:
> Please consider checking for s to be non-NULL.
Why?
You don't do that in the other internal_str* functions, right?

http://codereview.appspot.com/5668047/



More information about the llvm-commits mailing list