[llvm-commits] [dragonegg] r150175 - /dragonegg/trunk/include/dragonegg/Internals.h

David Blaikie dblaikie at gmail.com
Thu Feb 9 08:18:59 PST 2012


On Thu, Feb 9, 2012 at 6:30 AM, Duncan Sands <baldrick at free.fr> wrote:
> Author: baldrick
> Date: Thu Feb  9 08:30:58 2012
> New Revision: 150175
>
> URL: http://llvm.org/viewvc/llvm-project?rev=150175&view=rev
> Log:
> Flip the order so compilers won't report the cast to void as unreachable.
>
> Modified:
>    dragonegg/trunk/include/dragonegg/Internals.h
>
> Modified: dragonegg/trunk/include/dragonegg/Internals.h
> URL: http://llvm.org/viewvc/llvm-project/dragonegg/trunk/include/dragonegg/Internals.h?rev=150175&r1=150174&r2=150175&view=diff
> ==============================================================================
> --- dragonegg/trunk/include/dragonegg/Internals.h (original)
> +++ dragonegg/trunk/include/dragonegg/Internals.h Thu Feb  9 08:30:58 2012
> @@ -109,8 +109,8 @@
>  /// DieAbjectly - An unrecoverable fatal error occurred - throw in the towel,
>  /// give up the ghost, quit miserably.
>  inline void LLVM_ATTRIBUTE_NORETURN DieAbjectly(const char *Message) {
> -  llvm_unreachable(Message);
>   (void)Message; // Avoid unused variable warning when assertions are disabled.

does this actually need to be here at all? I didn't think
llvm_unreachable compiled down to nothing when assertions are
disabled...

> +  llvm_unreachable(Message);
>  }
>  inline void LLVM_ATTRIBUTE_NORETURN DieAbjectly(const char *Message,
>                                                 union gimple_statement_d *stmt){
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list