[llvm-commits] [llvm] r150060 - in /llvm/trunk: include/llvm/IntrinsicsX86.td lib/Target/X86/X86ISelLowering.cpp lib/Target/X86/X86InstrSSE.td

[Craig Topper]

On Thu, Feb 9, 2012 at 1:19 AM, Duncan Sands <baldrick at free.fr> wrote:

> Hi Craig,
>
>
>     I see that you removed all clang support for these builtins, rather
>> than having
>>    clang turn the builtin into a shufflevector instruction (which is what
>> I thought
>>    you did).  Is that wise?  You just reduced GCC compatibility, when you
>> could
>>    have kept it by expanding the builtins into generic IR.
>>
>>    Ciao, Duncan.
>>
>>
>> That's correct, but what I did is no different than what is already done
>> for
>> pshufd, shufps/pd, punpckl*, punpckh*, unpcklps/pd, unpckhps/pd, pshuflw,
>> pshufhw, etc.
>>
>
> was it really a good idea to remove them?  You could have had clang
> support them
> at little cost, maintaining GCC compatibility.
>
>
I only removed builtins for a couple avx/avx2 instruction, vpermil* and
vperm2(f/i)128. pshufd and the others already didn't exist before I got
here.


> Ciao, Duncan.
>



-- 
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120209/3a341368/attachment.html>