[llvm-commits] [PATCH 01/13] Add For Loop Structures

[David A. Greene]

Jakob Stoklund Olesen <stoklund at 2pi.dk> writes:

> The roundtrip delay on pre-commit reviews makes it necessary to review
> larger changes than one would normally commit directly. 

Ah.  I'm assuming I should submit the patch as review, not break
it up.  Is that right?

> In the present case, I think the granularity you chose is fine: 1. Add
> a single-variable foreach loop. 2. Zip.

Ok.  I thought zip was a no-go.  I'm going to wait on it anyway while I
work out how various things might work.  It may or may not come back.

> If you need to make changes that reach into other parts of the code,
> they should be submitted and reviewed independently. Always make sure
> reviewers know why you need to make the change.

Sure.  Thanks for your help!

                          -Dave