[llvm-commits] PATCH: AddressSanitizer: start factoring out interception machinery (issue 5642046)

Kostya Serebryany kcc at google.com
Tue Feb 7 10:01:04 PST 2012


In general, this is what we need.

- Please make sure that the real_* functions reside in a proper namespace.
Maybe you will need one more parameter to the macros (namespace name).
- The functions from the interception interfaces should reside in some
namspace  or have a __ prefix (__interception?)
- try to resolve FIXME's

--kcc


On Tue, Feb 7, 2012 at 4:30 AM, <samsonov at google.com> wrote:

> Reviewers: kcc, ramosian.glider, timurrrr_at_google_com,
>
>
>
> Please review this at http://codereview.appspot.com/**5642046/<http://codereview.appspot.com/5642046/>
>
> Affected files:
>  M     Makefile.mk
>  M     Makefile.old
>  M     asan_interceptors.cc
>  M     asan_interceptors.h
>  M     asan_mac.cc
>  M     asan_malloc_mac.cc
>  A     interception/Makefile.mk
>  A     interception/interception.h
>  A     interception/interception_**linux.cc
>  A     interception/interception_mac.**cc
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120207/46ae78df/attachment.html>


More information about the llvm-commits mailing list