[llvm-commits] Implement the GET_CALLER_PC macro, stub the GET_CURRENT_FRAME macro (issue 5630065)

timurrrr at google.com timurrrr at google.com
Tue Feb 7 04:51:08 PST 2012


http://codereview.appspot.com/5630065/diff/1/lib/asan/asan_internal.h
File lib/asan/asan_internal.h (right):

http://codereview.appspot.com/5630065/diff/1/lib/asan/asan_internal.h#newcode24
lib/asan/asan_internal.h:24: # include <intrin.h>
On 2012/02/06 19:18:31, kcc wrote:
> Can we avoid this include in the header?
> ( I am not sure we can, just asking)
I doubt so.
Or we'll need to #include it in every file which uses GET_CURRENT_PC or
GET_BP_PC_SP.

Following the "include what you use" rule, we have to include here.

http://codereview.appspot.com/5630065/diff/1/lib/asan/asan_internal.h#newcode218
lib/asan/asan_internal.h:218:
(uintptr_t)__builtin_extract_return_address(__builtin_return_address(0))
The other one works too, but up to you
(reverted)

On 2012/02/06 19:18:31, kcc wrote:
> I'd keep this as as, it works.

http://codereview.appspot.com/5630065/diff/1/lib/asan/asan_internal.h#newcode222
lib/asan/asan_internal.h:222: // TODO(timurrrr): We don't unwind on
Windows - do we need this?
On 2012/02/06 19:18:31, kcc wrote:
> What do you mean "we don't unwind"?
> Also, better use FIXME instead of TODO(user)

Done.

http://codereview.appspot.com/5630065/



More information about the llvm-commits mailing list