[llvm-commits] PATCH: Efficient constant uniquing

[Talin]

On Sun, Feb 5, 2012 at 11:17 AM, Chris Lattner <clattner at apple.com> wrote:

>
> On Feb 4, 2012, at 11:16 PM, Talin wrote:
>
> This patch improves performance and memory usage for uniquing of
> ConstantStruct, ConstantArray, and ConstantVector. It's been verified to
> work both by myself and Meador Inge.
>
> I'm posting it here because I wasn't sure if attaching it to the bug (
> http://llvm.org/bugs/show_bug.cgi?id=1210) was sufficient to get approval
> for submission.
>
>
> Looks great to me.  It is unfortuanate that you have to manually write out
> the hashing logic like that, but it's fine with me.  2x memory reduction is
> huge!
>

OK it's in.

It would be possible to refactor the hashing logic - I was thinking of
introducing a Hashing.h to ADT.

>
> -Chris
>
>


-- 
-- Talin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120205/06f3735b/attachment.html>