[llvm-commits] [llvm] r149667 - /llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp

[Chad Rosier]

On Feb 3, 2012, at 10:17 AM, Owen Anderson <resistor at mac.com> wrote:

> 
> On Feb 2, 2012, at 8:13 PM, Cameron Zwarich wrote:
> 
>> Author: zwarich
>> Date: Thu Feb  2 22:13:37 2012
>> New Revision: 149667
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=149667&view=rev
>> Log:
>> Fix llvm-objdump disassembly for interesting Mach-O binaries, e.g. any MacOS
>> dylib. This regressed with r145408. I will try to make a test case and add it
>> so that this doesn't happen again.
>> 
>> Modified:
>>   llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
>> 
>> Modified: llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp?rev=149667&r1=149666&r2=149667&view=diff
>> ==============================================================================
>> --- llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp (original)
>> +++ llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp Thu Feb  2 22:13:37 2012
>> @@ -189,6 +189,8 @@
>>      if (!error(i->containsSymbol(*si, contains)) && contains) {
>>        uint64_t Address;
>>        if (error(si->getAddress(Address))) break;
>> +        Address -= SectionAddr;
>> +
> 
> This indentation is misleading.

It's flush with the 'if' statement in the source.  The commit message is the one being misleading. :)
 
Chad

> --Owen
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits