[llvm-commits] [llvm] r149348 - /llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

[Argyrios Kyrtzidis]

On Jan 31, 2012, at 12:44 PM, Chris Lattner wrote:

> 
> On Jan 31, 2012, at 9:32 AM, NAKAMURA Takumi wrote:
> 
>> 2012/1/31 Chris Lattner <sabre at nondot.org>:
>>> Author: lattner
>>> Date: Mon Jan 30 22:39:22 2012
>>> New Revision: 149348
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=149348&view=rev
>>> Log:
>>> rework this logic to not depend on the last argument to GetConstantStringInfo,
>>> which is going away.
>> 
>> Chris, it seems it might trigger a failure on
>> stage2(stage1-built-clang) build on my two builders, x86_64-linux and
>> i686-cygwin. I have not investigated why yet.
> 
> Hi Takumi,
> 
> Is this still failing for you?  I cannot reproduce this, and it is very strange.  I didn't change anything around metadata, so I'm not sure how I could have caused this.

Here's how to reproduce:

-Build llvm/clang
-Build Release+Asserts llvm/clang again with the newly built clang
-VMCoreTests fails

Apologies, I wasn't successful in untangling your changes without build or test failures, I ended up reverting all your commits up to the offending r149348:

r149348
r149351
r149352
r149354
r149356
r149357
r149361
r149362
r149364
r149365

Reverted in r149470.

-Argyrios


> 
> -Chris
> 
>> 
>> ...Takumi
>> 
>> ******************** TEST 'LLVM-Unit ::
>> VMCore/Release/VMCoreTests/MDStringTest.PrintingComplex' FAILED
>> ********************Note: Google Test filter =
>> MDStringTest.PrintingComplex
>> [==========] Running 1 test from 1 test case.
>> [----------] Global test environment set-up.
>> [----------] 1 test from MDStringTest
>> [ RUN      ] MDStringTest.PrintingComplex
>> /home/bb/buildslave/clang-3stage-x86_64-linux/llvm-project/llvm/unittests/VMCore/MetadataTest.cpp:71:
>> Failure
>> Value of: oss.str().c_str()
>> Actual: "metadata !"\00\00\00\00\00""
>> Expected: "metadata !\"\\00\\0A\\22\\5C\\FF\""
>> Which is: "metadata !"\00\0A\22\5C\FF""
>> [  FAILED  ] MDStringTest.PrintingComplex (0 ms)
>> [----------] 1 test from MDStringTest (0 ms total)
>> 
>> [----------] Global test environment tear-down
>> [==========] 1 test from 1 test case ran. (0 ms total)
>> [  PASSED  ] 0 tests.
>> [  FAILED  ] 1 test, listed below:
>> [  FAILED  ] MDStringTest.PrintingComplex
>> 
>> 1 FAILED TEST
>> 
>> ********************
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits