[llvm-commits] [PATCH] AddressSanitizer: do not wrap memcpy() on Mac OS 10.7

Alexander Potapenko glider at google.com
Tue Jan 31 11:56:06 PST 2012


I think it's better not to. We may miss something interesting on 10.6


On Tue, Jan 31, 2012 at 10:27 PM, Kostya Serebryany <kcc at google.com> wrote:
> Looks good.
> But maybe we should simply drop memcpy on all variants of MacOS?
>
> --kcc
>
>
> On Tue, Jan 31, 2012 at 5:36 AM, Alexander Potapenko <glider at google.com>
> wrote:
>>
>> The attached patch disables wrapping memcpy() on Mac OS Lion, where it
>> actually falls back to memmove.
>> In this case we still need to initialize real_memcpy, so we set it to
>> real_memmove
>> We check for MACOS_VERSION_SNOW_LEOPARD, because currently only Snow
>> Leopard and Lion are supported.
>>
>> --
>> Alexander Potapenko
>> Software Engineer
>> Google Moscow
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow



More information about the llvm-commits mailing list