[llvm-commits] PATCH: Add 64-bit architecture predicate to llvm::Triple

[Chandler Carruth]

On Mon, Jan 30, 2012 at 10:08 AM, James Molloy <james.molloy at arm.com> wrote:

>  Hi Chandler,****
>
> ** **
>
> One point:****
>
> ** **
>
> +  /// Note that this tests for 16-bit pointer width, and nothing else.***
> *
>
> ** **
>
> I’m not sure this comment is accurate. For example, real mode x86 would be
> 16-bit but has 24-bit pointers (seg:offset).
>

As far as I can tell, there is no support for x86-16 or real mode or any of
the other segmented addressing modes on x86. If such modes are added, I
would be quite happy for them to return false on all three of these
queries. ;] I still think "pointer size" is the most descriptive term, but
I'm open to more suggestions.

FWIW, the reason I don't particularly like "native width of the register
file" is that i find it much less clear and unambiguous given the diversity
of register widths on even modern architectures. However, addresses
generally have a fixed size on modern architectures, and so that seems a
good classification scheme.

I'm planning to go ahead and submit this, we can tweak the wording in
post-commit until the bike shed is just the right shade. ;]
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120130/563237ec/attachment.html>