[llvm-commits] [llvm] r149309 - /llvm/trunk/include/llvm/ADT/IntrusiveRefCntPtr.h

[David Blaikie]

On Mon, Jan 30, 2012 at 4:57 PM, Ted Kremenek <kremenek at apple.com> wrote:
> Author: kremenek
> Date: Mon Jan 30 18:57:08 2012
> New Revision: 149309
>
> URL: http://llvm.org/viewvc/llvm-project?rev=149309&view=rev
> Log:
> Relax constructor for IntrusiveRefCntPtr to not be explicit.
>
> Modified:
>    llvm/trunk/include/llvm/ADT/IntrusiveRefCntPtr.h
>
> Modified: llvm/trunk/include/llvm/ADT/IntrusiveRefCntPtr.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/IntrusiveRefCntPtr.h?rev=149309&r1=149308&r2=149309&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/ADT/IntrusiveRefCntPtr.h (original)
> +++ llvm/trunk/include/llvm/ADT/IntrusiveRefCntPtr.h Mon Jan 30 18:57:08 2012
> @@ -115,7 +115,7 @@
>
>     explicit IntrusiveRefCntPtr() : Obj(0) {}
>
> -    explicit IntrusiveRefCntPtr(T* obj) : Obj(obj) {
> +    IntrusiveRefCntPtr(T* obj) : Obj(obj) {

It seems to be the convention in some other parts of clang that
deliberately implicit ctors are prefixed with /*implicit*/ like this:

/*implicit*/ IntrusiveRefCntPtr(T* obj) : Obj(obj) {

>       retain();
>     }
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits