[llvm-commits] Resubmittal of Mips big endian changes

[Rafael Espíndola]

On 23 January 2012 21:22, Carter, Jack <jcarter at mips.com> wrote:
> Resubmittal for Mips big endian patch with minimal 64 bit support.
> The 64 bit support caused a rethink of how we constructed some
> of our objects and thus the inclusion.
>
> big_endian.patch

Hi Carter,
I am uncomfortable reviewing this patch as is. It is very big and
includes a mix of independent fixes, formatting changes, class
renaming and refactoring. It also includes no tests.

Please split this into smaller patches. A patch can include just the
reformatting, another one can add support for 64 bits, etc. Also,
please do write MC tests using .s files. I added a skeleton parser, so
you should be able to test simple things already. For example, testing
that a file is 64 bits can be done with an empty assembly file.

>
> Jack
>

Cheers,
Rafael