[llvm-commits] [llvm] r149163 - /llvm/trunk/lib/CodeGen/RegisterCoalescer.cpp

[Lang Hames]

Author: lhames
Date: Fri Jan 27 19:17:01 2012
New Revision: 149163

URL: http://llvm.org/viewvc/llvm-project?rev=149163&view=rev
Log:
Remove code that adds live ranges for dead defs. It seems to be breaking things.

Modified:
    llvm/trunk/lib/CodeGen/RegisterCoalescer.cpp

Modified: llvm/trunk/lib/CodeGen/RegisterCoalescer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/RegisterCoalescer.cpp?rev=149163&r1=149162&r2=149163&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/RegisterCoalescer.cpp (original)
+++ llvm/trunk/lib/CodeGen/RegisterCoalescer.cpp Fri Jan 27 19:17:01 2012
@@ -841,19 +841,6 @@
   TII->reMaterialize(*MBB, MII, DstReg, 0, DefMI, *TRI);
   MachineInstr *NewMI = prior(MII);
 
-  // NewMI may have dead implicit defs (E.g. EFLAGS for MOV<bits>r0 on X86).
-  // We need to remember these so we can add intervals once we insert
-  // NewMI into SlotIndexes.
-  SmallVector<unsigned, 4> NewMIImplDefs;
-  for (unsigned i = NewMI->getDesc().getNumOperands(),
-         e = NewMI->getNumOperands(); i != e; ++i) {
-    MachineOperand &MO = NewMI->getOperand(i);
-    if (MO.isReg()) {
-      assert(MO.isDef() && MO.isImplicit() && MO.isDead());
-      NewMIImplDefs.push_back(MO.getReg());
-    }
-  }
-
   // CopyMI may have implicit operands, transfer them over to the newly
   // rematerialized instruction. And update implicit def interval valnos.
   for (unsigned i = CopyMI->getDesc().getNumOperands(),
@@ -866,17 +853,6 @@
   }
 
   LIS->ReplaceMachineInstrInMaps(CopyMI, NewMI);
-
-  SlotIndex NewMIIdx = LIS->getInstructionIndex(NewMI);
-  for (unsigned i = 0, e = NewMIImplDefs.size(); i != e; ++i) {
-    unsigned reg = NewMIImplDefs[i];
-    LiveInterval &li = LIS->getInterval(reg);
-    VNInfo *DeadDefVN = li.getNextValue(NewMIIdx.getRegSlot(), 0,
-                                        LIS->getVNInfoAllocator());
-    LiveRange lr(NewMIIdx.getRegSlot(), NewMIIdx.getDeadSlot(), DeadDefVN);
-    li.addRange(lr);
-  }
-
   NewMI->copyImplicitOps(CopyMI);
   CopyMI->eraseFromParent();
   ReMatCopies.insert(CopyMI);