[llvm-commits] [PATCH][AddressSanitizer] Make lib\asan compileable using Visual Studio

Timur Iskhodzhanov timurrrr at google.com
Fri Jan 27 07:10:27 PST 2012


OK, removed it.

Please take another look.

Thanks,
Timur

On Fri, Jan 27, 2012 at 6:49 PM, Alexander Potapenko <glider at google.com> wrote:
> +  unsigned long ret = -1;  // NOLINT
> +  _BitScanForward64(&ret, x);
> +  return ret;
> +#elif defined(_WIN32)
> +  unsigned long ret = -1;  // NOLINT
>
> Why do you need this initial value? This is not required from
> __builtin_clz-like functions, and anyway checking for x to be nonzero
> is better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: win.patch
Type: text/x-patch
Size: 6454 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120127/8de55204/attachment.bin>


More information about the llvm-commits mailing list