[llvm-commits] [PATCH] Splitting the RuntimeDyldImpl.h header

Bendersky, Eli eli.bendersky at intel.com
Sat Jan 21 23:09:13 PST 2012

Thanks for the review. Committed in r148652

From: Jim Grosbach [mailto:grosbach at apple.com]
Sent: Thursday, January 19, 2012 19:21
To: Bendersky, Eli
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [PATCH] Splitting the RuntimeDyldImpl.h header

Hi Eli,

Looks good to me. Thanks!


On Jan 19, 2012, at 4:12 AM, Bendersky, Eli wrote:


I'm attaching a very simple patch that splits the lib/ExecutionEngine/RuntimeDyld/RuntimeDyldImpl.h header into smaller logical headers. The RuntimeDyldELF class declaration moves to RuntimeDyldELF.h and the RuntimeDyldMachO class declaration moves to RuntimeDyldMachO.h, with the includes adjusted accordingly.

This change cleans up the code, since the container-specific RuntimeDyld classes start growing in complexity and there's little sense keeping them all in a single big header.

Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120122/99088856/attachment.html>

More information about the llvm-commits mailing list