[llvm-commits] [llvm] r148543 - /llvm/trunk/lib/MC/MCDwarf.cpp

[Benjamin Kramer]

On 20.01.2012, at 17:25, David Blaikie wrote:

> This looks like it was totally broken - is there a missing test case?

It's just debug output, probably not worth testing.

- Ben

> From: Benjamin Kramer
> Sent: 1/20/2012 6:50 AM
> To: llvm-commits at cs.uiuc.edu
> Subject: [llvm-commits] [llvm] r148543 - /llvm/trunk/lib/MC/MCDwarf.cpp
> Author: d0k
> Date: Fri Jan 20 08:42:37 2012
> New Revision: 148543
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=148543&view=rev
> Log:
> Add missing breaks to switch.
> 
> Found by the clang static analyzer.
> 
> Modified:
>    llvm/trunk/lib/MC/MCDwarf.cpp
> 
> Modified: llvm/trunk/lib/MC/MCDwarf.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCDwarf.cpp?rev=148543&r1=148542&r2=148543&view=diff
> ==============================================================================
> --- llvm/trunk/lib/MC/MCDwarf.cpp (original)
> +++ llvm/trunk/lib/MC/MCDwarf.cpp Fri Jan 20 08:42:37 2012
> @@ -856,28 +856,40 @@
> static void EmitEncodingByte(MCStreamer &Streamer, unsigned Encoding,
>                              StringRef Prefix) {
>   if (Streamer.isVerboseAsm()) {
> -    const char *EncStr = 0;
> +    const char *EncStr;
>     switch (Encoding) {
> -    default: EncStr = "<unknown encoding>";
> -    case dwarf::DW_EH_PE_absptr: EncStr = "absptr";
> -    case dwarf::DW_EH_PE_omit:   EncStr = "omit";
> -    case dwarf::DW_EH_PE_pcrel:  EncStr = "pcrel";
> -    case dwarf::DW_EH_PE_udata4: EncStr = "udata4";
> -    case dwarf::DW_EH_PE_udata8: EncStr = "udata8";
> -    case dwarf::DW_EH_PE_sdata4: EncStr = "sdata4";
> -    case dwarf::DW_EH_PE_sdata8: EncStr = "sdata8";
> -    case dwarf::DW_EH_PE_pcrel |dwarf::DW_EH_PE_udata4: EncStr =
> "pcrel udata4";
> -    case dwarf::DW_EH_PE_pcrel |dwarf::DW_EH_PE_sdata4: EncStr =
> "pcrel sdata4";
> -    case dwarf::DW_EH_PE_pcrel |dwarf::DW_EH_PE_udata8: EncStr =
> "pcrel udata8";
> -    case dwarf::DW_EH_PE_pcrel |dwarf::DW_EH_PE_sdata8: EncStr =
> "pcrel sdata8";
> +    default: EncStr = "<unknown encoding>"; break;
> +    case dwarf::DW_EH_PE_absptr: EncStr = "absptr"; break;
> +    case dwarf::DW_EH_PE_omit:   EncStr = "omit"; break;
> +    case dwarf::DW_EH_PE_pcrel:  EncStr = "pcrel"; break;
> +    case dwarf::DW_EH_PE_udata4: EncStr = "udata4"; break;
> +    case dwarf::DW_EH_PE_udata8: EncStr = "udata8"; break;
> +    case dwarf::DW_EH_PE_sdata4: EncStr = "sdata4"; break;
> +    case dwarf::DW_EH_PE_sdata8: EncStr = "sdata8"; break;
> +    case dwarf::DW_EH_PE_pcrel | dwarf::DW_EH_PE_udata4:
> +      EncStr = "pcrel udata4";
> +      break;
> +    case dwarf::DW_EH_PE_pcrel | dwarf::DW_EH_PE_sdata4:
> +      EncStr = "pcrel sdata4";
> +      break;
> +    case dwarf::DW_EH_PE_pcrel | dwarf::DW_EH_PE_udata8:
> +      EncStr = "pcrel udata8";
> +      break;
> +    case dwarf::DW_EH_PE_pcrel | dwarf::DW_EH_PE_sdata8:
> +      EncStr = "screl sdata8";
> +      break;
>     case dwarf::DW_EH_PE_indirect
> |dwarf::DW_EH_PE_pcrel|dwarf::DW_EH_PE_udata4:
>       EncStr = "indirect pcrel udata4";
> +      break;
>     case dwarf::DW_EH_PE_indirect
> |dwarf::DW_EH_PE_pcrel|dwarf::DW_EH_PE_sdata4:
>       EncStr = "indirect pcrel sdata4";
> +      break;
>     case dwarf::DW_EH_PE_indirect
> |dwarf::DW_EH_PE_pcrel|dwarf::DW_EH_PE_udata8:
>       EncStr = "indirect pcrel udata8";
> +      break;
>     case dwarf::DW_EH_PE_indirect
> |dwarf::DW_EH_PE_pcrel|dwarf::DW_EH_PE_sdata8:
>       EncStr = "indirect pcrel sdata8";
> +      break;
>     }
> 
>     Streamer.AddComment(Twine(Prefix) + " = " + EncStr);
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits