[llvm-commits] Please allow llvm to support armhf hardware / toolchain

[Rafael Ávila de Espíndola]

On 10/01/12 02:24 PM, Sylvestre Ledru wrote:
> Hello,
> 
> It would be nice if you could apply the attached patch. It has been
> generated against the last llvm svn.
> It allows LLVM to run on Arm Hard Float CPU (armhf or called also
> armv7).
> 
> A new gcc triple has been introduced which requires LLVM to be updated.
> 
> It builds without any problem:
> https://buildd.debian.org/status/fetch.php?pkg=llvm-3.0&arch=armhf&ver=3.0-5&stamp=1324362164
> 
> More information on the Debian port:
> http://wiki.debian.org/ArmHardFloatPort
> 
> and the impact of this triple on llvm:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=642127

The LLVM patch is OK, but you also have to update clang, no? The switch

    // Select the default based on the platform.
    switch(Triple.getEnvironment()) {
    case llvm::Triple::ANDROIDEABI:
    case llvm::Triple::GNUEABI:
      ABIName = "aapcs-linux";
      break;
    case llvm::Triple::EABI:
      ABIName = "aapcs";
      break;
    default:
      ABIName = "apcs-gnu";
    }

now selects apcs-gnu, which is probably not what you want.

> Thanks,
> Sylvestre
> PS: This has been initially reported here:
> http://llvm.org/bugs/show_bug.cgi?id=11670

Cheers,
Rafael