[llvm-commits] [llvm][PATCH][Review Requested] Fix failure to realign stack on x86
joerg at britannica.bec.de
Wed Jan 18 13:49:39 PST 2012
On Wed, Jan 18, 2012 at 12:53:58PM -0800, Jakob Stoklund Olesen wrote:
> If the Android x86 ABI doesn't specify a 16-byte aligned stack, you
> need to ensure that the TargetFrameLowering class knows that. Look at
> the X86Subtarget class.
Agreed on this. Preston, please also look at the stack-align2.ll test
case. If you have further test cases, e.g. realigning a function with
local variable has requires more than the default on some platforms,
please extend that test case. But the basic assumption is that if a
function is tagged to have the (default) stack alignment of 16, it can
and should safely assume so.
More information about the llvm-commits