[llvm-commits] Patch for pr11688: Fix sret calling convention for i686-pc-win32

Eli Friedman eli.friedman at gmail.com
Tue Jan 17 12:52:33 PST 2012

On Tue, Jan 17, 2012 at 11:38 AM, Joe Groff <arcata at gmail.com> wrote:
> Hi everyone. MSVC uses caller-cleanup for struct return pointers,
> unlike other i386 platforms (including mingw32). Attached is a patch
> against LLVM 3.0 that fixes this. Let me know if there are any
> necessary changes or additions. Thanks!

-  if (!Subtarget->is64Bit() && CS.paramHasAttr(1, Attribute::StructRet))
+  if (!Subtarget->is64Bit() && !Subtarget->isTargetWindows() &&
CS.paramHasAttr(1, Attribute::StructRet))

80 columns (also in other places).

Otherwise, this patch looks correct.


More information about the llvm-commits mailing list