[llvm-commits] [llvm] r148108 - in /llvm/trunk/lib/Target/X86: X86ISelLowering.cpp X86InstrInfo.cpp X86InstrSSE.td X86MCInstLower.cpp

[Jakob Stoklund Olesen]

On Jan 13, 2012, at 11:10 AM, Craig Topper wrote:

> How does foldMemoryOpImpl work for those patterns that are using subreg? Won't it only create a v4i32 constant pool entry?

There should be a safeguard so it doesn't get called at all. See InlineSpiller::foldMemoryOperand.

It that an important optimization? I was always a bit skeptical of converting V_SET0 into a constant pool load.

/jakob