[llvm-commits] [zorg] r148062 - /zorg/trunk/lnt/lnt/server/ui/views.py

[Daniel Dunbar]

Author: ddunbar
Date: Thu Jan 12 16:49:47 2012
New Revision: 148062

URL: http://llvm.org/viewvc/llvm-project?rev=148062&view=rev
Log:
[lnt/v0.4] lnt.server.ui/v4_graph: Fix a crash when displaying sample points.
 - Also, don't default linear regression line to on.
 - Also, show_all_points shouldn't also require checking show_points.

Modified:
    zorg/trunk/lnt/lnt/server/ui/views.py

Modified: zorg/trunk/lnt/lnt/server/ui/views.py
URL: http://llvm.org/viewvc/llvm-project/zorg/trunk/lnt/lnt/server/ui/views.py?rev=148062&r1=148061&r2=148062&view=diff
==============================================================================
--- zorg/trunk/lnt/lnt/server/ui/views.py (original)
+++ zorg/trunk/lnt/lnt/server/ui/views.py Thu Jan 12 16:49:47 2012
@@ -887,7 +887,7 @@
     options['show_all_points'] = show_all_points = bool(
         request.args.get('show_all_points'))
     options['show_linear_regression'] = show_linear_regression = bool(
-        request.args.get('show_linear_regression', True))
+        request.args.get('show_linear_regression'))
     options['show_failures'] = show_failures = bool(
         request.args.get('show_failures'))
 
@@ -954,15 +954,15 @@
         points_data = []
         pts = []
         for x,values in data:
-            pts.append((x, min(values)))
+            min_value = min(values)
+            pts.append((x, min_value))
 
             # Add the individual points, if requested.
-            if show_points:
-                if show_all_points:
-                    for v in values:
-                        points_data.append((x, v))
-                else:
-                    points_data.append((x, min_value))
+            if show_all_points:
+                for v in values:
+                    points_data.append((x, v))
+            elif show_points:
+                points_data.append((x, min_value))
 
             # Add the standard deviation error bar, if requested.
             if show_stddev: